Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.38.1 RC1 #5630

Merged
merged 5 commits into from
Feb 11, 2020
Merged

v0.38.1 RC1 #5630

merged 5 commits into from
Feb 11, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 10, 2020 •
edited
Loading

closes: #5574

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 10, 2020 •
edited
Loading

Codecov Report

Merging #5630 into rc1/v0.38.1 will increase coverage by 0.04%.
The diff coverage is 65.71%.

Impacted file tree graph

@@               Coverage Diff               @@
##           rc1/v0.38.1    #5630      +/-   ##
===============================================
+ Coverage        54.07%   54.11%   +0.04%     
===============================================
  Files              313      313              
  Lines            18968    18991      +23     
===============================================
+ Hits             10256    10277      +21     
- Misses            7914     7917       +3     
+ Partials           798      797       -1
Impacted Files Coverage Δ
x/staking/keeper/val_state_change.go 65.03% <0%> (-2.49%) ⬇️
x/gov/abci.go 95.31% <100%> (+0.07%) ⬆️
x/bank/internal/keeper/keeper.go 70.05% <100%> (+1.38%) ⬆️
x/staking/keeper/delegation.go 74.66% <87.5%> (+0.88%) ⬆️
x/mock/app.go 64.18% <0%> (+1.35%) ⬆️

@alexanderbez alexanderbez marked this pull request as ready for review February 10, 2020 19:42
@alexanderbez alexanderbez added R4R and removed WIP labels Feb 10, 2020
jackzampolin
jackzampolin approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @AdityaSripal, @alexanderbez and @ethanfrey on the IAVL pruning fixes! Looks like today is shipping day!

@alexanderbez alexanderbez merged commit 766ce82 into rc1/v0.38.1 Feb 11, 2020
@alexanderbez alexanderbez deleted the rc0/v0.38.1 branch February 11, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@zmanian zmanian Awaiting requested review from zmanian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @jackzampolin @migueldingli1997 @AdityaSripal